Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for forms and other complex Python/Django constructs (v2) #141

Merged
merged 7 commits into from
May 26, 2021

Conversation

ababic
Copy link
Contributor

@ababic ababic commented Mar 28, 2021

View description

Related issues: #113, #106, #134

Supersedes #140

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

@ababic ababic force-pushed the feature/context-modifiers branch 9 times, most recently from a5c79f2 to cf30c57 Compare March 29, 2021 22:10
@ababic ababic requested a review from bcdickinson May 13, 2021 10:34
@ababic ababic force-pushed the feature/context-modifiers branch from cf30c57 to fd9f248 Compare May 15, 2021 08:49
Copy link

@bcdickinson bcdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andy, this is looking great! There are one or two little points about typos and error messages, but once those are resolved, let's get this merged 😄

@ababic ababic force-pushed the feature/context-modifiers branch from fd9f248 to 8eafff0 Compare May 25, 2021 19:45
@ababic ababic force-pushed the feature/context-modifiers branch from 8eafff0 to 688b0bd Compare May 25, 2021 19:50
@ababic
Copy link
Contributor Author

ababic commented May 25, 2021

Thanks for the review @bcdickinson. All of those bits should be resolved now, and I have also added a CHANGELOG entry.

@bcdickinson
Copy link

Great, thanks Andy. Looking forward to using this!

@bcdickinson bcdickinson merged commit ebcc296 into torchbox:master May 26, 2021
@ababic ababic deleted the feature/context-modifiers branch May 28, 2021 08:50
@thibaudcolas
Copy link
Member

I’m trying to use this now and can’t get it running – there doesn’t seem to be anything loading the pattern_contexts files so the context modifiers can be registered, unless I’m missing something.

@thibaudcolas
Copy link
Member

I have pushed my work-in-progress here: #146.

Moving the code from pattern_contexts.py to urls.py seems to do the trick, so it looks like the only problem is the pattern library missing some code to load those pattern_contexts modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants