Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Data migration and update to service and sub-service page themes #495

Merged
merged 3 commits into from
Jul 4, 2023

Conversation

helenb
Copy link
Member

@helenb helenb commented Jun 23, 2023

Ticket: https://torchbox.monday.com/boards/1192293412/views/4019870

This removes the 'dark transparent header' theme from service and sub-service pages. (Note that the ticket refers to sub-proposition pages, but there is no page with this type defined)

Updates any existing pages using the 'dark transparent header' theme to use the light theme, then removes that option for service and sub-service pages.

Before:
Screenshot 2023-06-23 at 10 45 52

After:
Screenshot 2023-06-23 at 10 46 01

Note that it was decided to apply this to service page types as well as sub-service page types after the first work had been done - one data migration would probably have been preferable, but I couldn't reverse the first migration that I ran.

@helenb helenb requested a review from engineervix June 23, 2023 09:47
@helenb helenb changed the title Data migration and update to sub-service page themes Draft: Data migration and update to service and sub-service page themes Jun 23, 2023
@helenb helenb removed the request for review from engineervix June 23, 2023 10:06
@helenb helenb changed the title Draft: Data migration and update to service and sub-service page themes Data migration and update to service and sub-service page themes Jun 23, 2023
@helenb helenb requested a review from engineervix June 23, 2023 10:16
Copy link
Member

@engineervix engineervix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @helenb changes look good 👍

@engineervix
Copy link
Member

I've added a commit which combines the data migrations into one module.

@helenb helenb force-pushed the chore/dark-transparent-theme-sub-service-page branch from e9c8709 to 15791a1 Compare June 27, 2023 09:52
@zerolab zerolab temporarily deployed to torchbox-staging June 27, 2023 10:07 Inactive
@helenb helenb force-pushed the chore/dark-transparent-theme-sub-service-page branch from 357e07f to 7bdd47a Compare July 4, 2023 13:38
@helenb helenb merged commit 2467a27 into master Jul 4, 2023
2 checks passed
@helenb helenb deleted the chore/dark-transparent-theme-sub-service-page branch July 4, 2023 13:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants