This repository has been archived by the owner on Apr 24, 2024. It is now read-only.
Fixes to the badge colour and hover state in different themes #499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monday ticket
Description of Changes Made
Another little theme bugfix. I spotted that the mobile dropdown in the coral theme was not displaying the jobs badge as the fill colour was the same as the background colour. I then spotted that the hover effects on the badges aren't great either.
How to Test
Visit a page using the coral theme in your local build, reduce the screen size, and open the mobile drop-down menu to see the badge colour. Check the hover state too, and compare it to the colour and hover state in the desktop dropdown.
Repeat this for the other themes - compare to the live site to see the differences.
Check the badge colour and hover state in the dropdown menu on the home page, and compare to live to confirm this has not changed.
Before and after screencasts
Expand to see more
before.mov
after.mov
MR Checklist