Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Fixes to the badge colour and hover state in different themes #499

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

helenb
Copy link
Member

@helenb helenb commented Jun 27, 2023

Monday ticket

Description of Changes Made

Another little theme bugfix. I spotted that the mobile dropdown in the coral theme was not displaying the jobs badge as the fill colour was the same as the background colour. I then spotted that the hover effects on the badges aren't great either.

How to Test

Visit a page using the coral theme in your local build, reduce the screen size, and open the mobile drop-down menu to see the badge colour. Check the hover state too, and compare it to the colour and hover state in the desktop dropdown.

Repeat this for the other themes - compare to the live site to see the differences.

Check the badge colour and hover state in the dropdown menu on the home page, and compare to live to confirm this has not changed.

Before and after screencasts

Expand to see more
before.mov
after.mov

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Consider adding unit tests, especially for bug fixes. If you don't, tell us why.
  • Tests and linting passes.
  • Consider updating documentation. If you don't, tell us why.
  • If relevant, list the environments / browsers in which you tested your changes.

@helenb helenb changed the title Draft: Ensure that jobs badge displays correctly in the mobile dropdown in the coral theme Fixes to the badge colour and hover state in different themes Jun 27, 2023
@helenb helenb requested a review from albinazs June 27, 2023 13:16
Copy link
Collaborator

@albinazs albinazs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @helenb !

@helenb helenb force-pushed the fix/menu-drop-down-jobs-tag branch from 8aa72ad to 76a7c38 Compare July 4, 2023 13:15
@helenb helenb merged commit 47b4e7e into master Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants