Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Check client logo link with hcm #525

Conversation

chris-lawton
Copy link
Member

Adding the work done in the following MR to the integration branch to make the merge to staging easier as there's changes in the same files coming from both sets of work.

#522

Description of Changes Made

Don't add a link around the client logo as it's not a required field in Wagtail.

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Consider adding unit tests, especially for bug fixes. If you don't, tell us why.
  • Tests and linting passes.
  • Consider updating documentation. If you don't, tell us why.
  • If relevant, list the environments / browsers in which you tested your changes.

@chris-lawton chris-lawton mentioned this pull request Aug 16, 2023
7 tasks
@chris-lawton
Copy link
Member Author

Hi @helenb - this is an MR for the work done in #522 but with the high contrast work added in as well. Doing this will make the rebase on main and merge to staging easier : )

@helenb
Copy link
Member

helenb commented Aug 17, 2023

Thanks @chris-lawton please go ahead and merge to the HCM integration branch, and it will get deployed once that work is approved.

@helenb
Copy link
Member

helenb commented Aug 17, 2023

Thanks @chris-lawton please go ahead and merge to the HCM integration branch, and it will get deployed once that work is approved.

I've realised this is already deployed but this is just a fix to make the merge easier

@chris-lawton chris-lawton merged commit 00fadd8 into integration/hcm-accessibility-fixes Aug 17, 2023
2 checks passed
@chris-lawton chris-lawton deleted the fix/check-client-logo-link-with-hcm branch August 17, 2023 11:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants