Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Further HCM fixes and update style lint packages to cope with system colours (sort of) #526

Conversation

helenb
Copy link
Member

@helenb helenb commented Aug 17, 2023

Link to Ticket

Description of Changes Made

Adds link underline, and thicker underline on hover, to navigation items in HCM
Does the same for rich text links in HCM
Makes the 'More' button consistent with the HCM version in the careers site

How to Test

To test in high contrast mode, ensure 'forced colours: active' has been selected in dev tools under 'rendering'. Then adjust the 'prefers-color-scheme' option to light or dark and test both modes.

Test both the home page and an inner page. To test rich text links, edit a standard page and add a paragraph block and add a link to it.

Screenshots

Expand to see more Please ask if there are any screenshots you'd like to see in particular.

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Consider adding unit tests, especially for bug fixes. If you don't, tell us why.
  • Tests and linting passes.
  • Consider updating documentation. If you don't, tell us why.
  • If relevant, list the environments / browsers in which you tested your changes: Chrome plus dev tools to mimic HCM

package.json Show resolved Hide resolved
@helenb helenb requested review from jhancock532 and chris-lawton and removed request for jhancock532 August 17, 2023 09:19
@helenb helenb merged commit 10b5d44 into integration/hcm-accessibility-fixes Aug 18, 2023
2 checks passed
@helenb helenb deleted the feature/6515-hcm-for-nav-and-rich-text branch August 18, 2023 09:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants