-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update to passport-saml version 2.0.2
- Loading branch information
Showing
3 changed files
with
28 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba3e54e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I am having this error:
Error: Cannot set uncompiled validation rules without configuring a validator
On registering hapi-saml2 with hapijs 20.0.3 (Have the same problem with 19.X version).
I found out that the problem is on the file:
lib/controller/handlers/logout.js
Since hapi 19.0.0 release. Hapi change the joi Schema Compiler:
Reference:
hapijs/hapi#4017
To solve the error I have to change the require for joi from @hapi/joi to joi and to wrap the query object in to a Joi.object:
That solve the issue and now is working fine.
Could you validate this? Maybe you have a better solution.
ba3e54e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ovallef - this makes sense.
I'm considering removing the Joi dependency altogether. The value we gain from it is small and we can validate it with one less dependency