Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting a custom server with --server URL #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rpls
Copy link

@rpls rpls commented Jan 21, 2022

This is a simple patch for #221. Could probably use some more bells and whistles, e.g., a re.match to check the URL. But this works so far.

Closes #221

@kennyballou
Copy link

As an outsider wanting this patch to land, what's the usage? How do I actually specify my own URL for languagetool? Is it combined with another parameter I'm not seeing from the patch? Could you please add a bit to the README for how to use this?

@torik42
Copy link
Owner

torik42 commented Jan 12, 2023

If you just want to use this patch and merge yourself, you might want to look at #221.

If the intention is to have a more complete patch which will be merged soon, I have to say the following: The complete settings section of yalafi.shell in yalafi/shell/shell.py is messed up and needs to be cleaned. This patch indeed works but is not very clean in that it sets cmdline.server = 'lt'. Unfortunately, before I will come to that, I have some other things to fix. And fixing the interface and command line options might even require a new major release.

@kennyballou
Copy link

The instructions in #221 are sufficient for me if you want to merge this as is. Thank you.

kennyballou added a commit to kennyballou/guix-channel that referenced this pull request Jan 16, 2023
Copied from [0] but reapplied to the newer version of YaLafi.

[0]: torik42/YaLafi#222

Signed-off-by: Kenny Ballou <kb@devnulllabs.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: LanguageTool Issues related to LaguageTool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom LanguageTool Server URL
3 participants