Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: b' d' l' not supported in default solver #52

Closed
prendradjaja opened this issue Nov 12, 2020 · 1 comment · Fixed by #62
Closed

Bug: b' d' l' not supported in default solver #52

prendradjaja opened this issue Nov 12, 2020 · 1 comment · Fixed by #62

Comments

@prendradjaja
Copy link

Hello! This project's super useful to me, thanks for it!

How to reproduce:

  • cubeSolver.solve("b' ") throws Error: Invalid algorithm provided to algorithm parser
  • The same is true for d' and l'.
  • I'm using cube-solver v2.4.0

Looks like this is an intended use case, since cubeSolver.solve("f' ") works.

In case it's helpful: I took a short look and saw that somewhere along the way in evaluating .solve("b' "), we try to evaluate invertAlgorithm("z'' "), which gets rejected as invalid for having ' twice, but I wasn't able to track this down any further.

@prendradjaja prendradjaja changed the title Bug: b' d' l' not supported Bug: b' d' l' not supported in default solver Nov 12, 2020
@torjusti torjusti mentioned this issue Aug 8, 2021
torjusti added a commit that referenced this issue Aug 8, 2021
@torjusti
Copy link
Owner

torjusti commented Aug 8, 2021

Thanks and apoligies for the huge delay! I've fixed this and will be deploying it to NPM soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants