単語帳をタップした時に時々出るエラーの解決 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
間に合わなかったけどLGTM！w |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
目的
登録した単語帳をタップした時にエラーが出てクラッシュしたりしていた問題があったので、それの解決が必要だった。
更新内容
ref.readで良いところがref.watchになっちゃっていたのを直した。WordbookInfoListViewModelの持つ状態の型をAsyncValueに変更した。関連するIssue等
Fixes #55 #37
Tried to solve #58
レビューポイント
留意事項
残課題
AsyncValue.when(loading: )の時のCircularProgressIndicatorがめっちゃ横長になる問題RPReplay_Final1657950159.MP4