-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance parsing of Accept-Language quality values #2547
base: master
Are you sure you want to change the base?
Conversation
Thanks for your contribution! Can you add a simple test case for this functionality to |
@bdarnell Added a test case with all tests passing. |
Accept-language parsing was improved in #3068 so I think this PR is no longer needed; if there was something here that's not covered by that PR feel free to open a new one. |
no, this is an additional MR on top of #3068 - and already rebased up on it. please reopen. |
Ah, OK. In that case my comment about the deeply-nested generator expression inside a for loop expression still stands. |
The following cases were not possible: "Accept-Language: en-US; foo=bar; q=0.9" "Accept-Language: en-US; q = 0.9"
Parse HTTP syntax correctly:
Accept-Language: en-US ; foo=bar; q=2.0
was not possible and is now possible.