[WIP] Ensure all futures+signals are closed when stream is closed. #2652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 30, 2019
|
@bdarnell would you mind giving me some guidance on how you'd write a test for this? Would you like me create a new unit test for the |
|
Ideally I'd like to test this using only public interfaces. We're missing coverage of some case here - something to do with a client closing while it's its turn to speak? Maybe something involving multiple threads that we can't simulate with a single-threaded async test? I was hoping that examining the failing jupyterlab test cases would yield some clues here. |
jasongrout
referenced
this pull request
in jupyterlab/jupyterlab
May 8, 2019
…blishing. This will make it easier to inspect the work at each step before pushing it out to the world.
|
Closing in favor of #2670. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2651. See discussion there.
I still need to write a small test for this PR. I'll ping once I have this finished.