Merge #593: Fix halt channel closed after starting HTTP tracker

ba4cb34 feat: improve logging for HTTP tracker bootstrapping (Jose Celano)
9f3f949 fix: [#592] halt channel closed after starting HTTP tracker (Jose Celano)

Pull request description:

  Fix "halt" channel closed after starting HTTP tracker.

ACKs for top commit:
  josecelano:
    ACK ba4cb34

Tree-SHA512: e7a2b9ea7f6e73019364f20d2ca513343a9808d3beee4d6dbb898447484101af355696d3394a4f26e0ee9d33e4eadc85f918ffb0181177f953bbdac436eb3b2a

src/bootstrap/jobs/http_tracker.rs

@@ -59,6 +59,10 @@ async fn start_v1(socket: SocketAddr, tls: Option<RustlsConfig>, tracker: Arc<co
         .expect("it should be able to start to the http tracker");
 
     tokio::spawn(async move {
+        assert!(
+            !server.state.halt_task.is_closed(),
+            "Halt channel for HTTP tracker should be open"
+        );
         server
             .state
             .task

src/servers/http/server.rs

@@ -6,6 +6,7 @@ use axum_server::tls_rustls::RustlsConfig;
 use axum_server::Handle;
 use derive_more::Constructor;
 use futures::future::BoxFuture;
+use log::info;
 use tokio::sync::oneshot::{Receiver, Sender};
 
 use super::v1::routes::router;
@@ -51,6 +52,9 @@ impl Launcher {
         ));
 
         let tls = self.tls.clone();
+        let protocol = if tls.is_some() { "https" } else { "http" };
+
+        info!(target: "HTTP Tracker", "Starting on: {protocol}://{}", address);
 
         let running = Box::pin(async {
             match tls {
@@ -67,6 +71,8 @@ impl Launcher {
             }
         });
 
+        info!(target: "HTTP Tracker", "Started on: {protocol}://{}", address);
+
         tx_start
             .send(Started { address })
             .expect("the HTTP(s) Tracker service should not be dropped");