Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix services bootstraping #629

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Jan 19, 2024

This fixes all errors introduced after merging this PR.

  • HTTP tracker should not be started if it's disabled

Error running the Health Check API server:

thread 'tokio-runtime-worker' panicked at src/servers/signals.rs:52:25:
Failed to install stop signal: channel closed

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (203ce96) 77.62% compared to head (17296cd) 77.56%.

Files Patch % Lines
src/bootstrap/jobs/health_check_api.rs 0.00% 9 Missing ⚠️
src/app.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #629      +/-   ##
===========================================
- Coverage    77.62%   77.56%   -0.06%     
===========================================
  Files          125      125              
  Lines         8334     8337       +3     
===========================================
- Hits          6469     6467       -2     
- Misses        1865     1870       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This fixes this error:

```
Loading default configuration file: `./share/default/config/tracker.development.sqlite3.toml` ...
2024-01-19T12:43:24.605765751+00:00 [torrust_tracker::bootstrap::logging][INFO] logging initialized.
2024-01-19T12:43:24.606305647+00:00 [torrust_tracker::bootstrap::jobs::http_tracker][INFO] Note: Not loading Http Tracker Service, Not Enabled in Configuration.
2024-01-19T12:43:24.606314967+00:00 [torrust_tracker::bootstrap::jobs][INFO] TLS not enabled
thread 'tokio-runtime-worker' panicked at src/servers/registar.rs:84:32:
it should receive the listing: RecvError(())
```
@josecelano josecelano force-pushed the 626-panic-running-tracker-after-merging-pr branch from bf4a8d4 to bbf1be6 Compare January 19, 2024 14:12
@josecelano josecelano linked an issue Jan 19, 2024 that may be closed by this pull request
@josecelano josecelano added the Bug Incorrect Behavior label Jan 19, 2024
@josecelano josecelano self-assigned this Jan 19, 2024
@josecelano
Copy link
Member Author

josecelano commented Jan 19, 2024

Clean log after applying these patches:

Loading default configuration file: `./share/default/config/tracker.development.sqlite3.toml` ...
2024-01-19T15:23:49.393379822+00:00 [torrust_tracker::bootstrap::logging][INFO] logging initialized.
2024-01-19T15:23:49.393981937+00:00 [UDP Tracker][INFO] Starting on: udp://0.0.0.0:6969
2024-01-19T15:23:49.394000917+00:00 [UDP Tracker][INFO] Started on: udp://0.0.0.0:6969
2024-01-19T15:23:49.394017616+00:00 [torrust_tracker::bootstrap::jobs][INFO] TLS not enabled
2024-01-19T15:23:49.394114196+00:00 [HTTP Tracker][INFO] Starting on: http://0.0.0.0:7070
2024-01-19T15:23:49.394137515+00:00 [HTTP Tracker][INFO] Started on: http://0.0.0.0:7070
2024-01-19T15:23:49.394145365+00:00 [torrust_tracker::bootstrap::jobs][INFO] TLS not enabled
2024-01-19T15:23:49.394236295+00:00 [API][INFO] Starting on http://127.0.0.1:1212
2024-01-19T15:23:49.394261364+00:00 [API][INFO] Started on http://127.0.0.1:1212
2024-01-19T15:23:49.394273504+00:00 [Health Check API][INFO] Starting on: http://127.0.0.1:1313
2024-01-19T15:23:49.394296564+00:00 [Health Check API][INFO] Started on: http://127.0.0.1:1313

<---- AFTER SHUTDOWN WITH CRTL+C --->

2024-01-19T15:26:48.693839265+00:00 [torrust_tracker][INFO] Torrust shutting down..
2024-01-19T15:26:48.693860655+00:00 [torrust_tracker::servers::signals][INFO] Global shutdown signal processed
2024-01-19T15:26:48.693881535+00:00 [torrust_tracker::servers::signals][INFO] Shutting down UDP server on socket address: udp://0.0.0.0:6969
2024-01-19T15:26:48.693839795+00:00 [torrust_tracker::servers::signals][INFO] Global shutdown signal processed
2024-01-19T15:26:48.693891505+00:00 [torrust_tracker::servers::signals][INFO] shutting down http server on socket address: 127.0.0.1:1313
2024-01-19T15:26:48.693894035+00:00 [torrust_tracker::servers::signals][INFO] Sending graceful shutdown signal
!! shuting down in 90 seconds !!
2024-01-19T15:26:48.693908885+00:00 [torrust_tracker::servers::signals][INFO] Global shutdown signal processed
2024-01-19T15:26:48.693911415+00:00 [torrust_tracker::servers::signals][INFO] Shutting down HTTP server on socket address: 0.0.0.0:7070
2024-01-19T15:26:48.693913215+00:00 [torrust_tracker::servers::signals][INFO] Sending graceful shutdown signal
!! shuting down in 90 seconds !!
2024-01-19T15:26:48.693924044+00:00 [Health Check API][INFO] Stopped server running on: http://127.0.0.1:1313
2024-01-19T15:26:48.693935244+00:00 [torrust_tracker::bootstrap::jobs::torrent_cleanup][INFO] Stopping torrent cleanup job..
2024-01-19T15:26:48.693941384+00:00 [torrust_tracker::servers::signals][INFO] Global shutdown signal processed
2024-01-19T15:26:48.693978024+00:00 [torrust_tracker::servers::signals][INFO] Shutting down tracker API server on socket address: 127.0.0.1:1212
2024-01-19T15:26:48.693981474+00:00 [torrust_tracker::servers::signals][INFO] Sending graceful shutdown signal
!! shuting down in 90 seconds !!
2024-01-19T15:26:48.694181342+00:00 [torrust_tracker][INFO] Torrust successfully shutdown.

This fixes:

- The error: "Failed to install stop signal: channel closed"
- And CRTL+C to shutdown the service
@josecelano
Copy link
Member Author

ACK 17296cd

@josecelano josecelano marked this pull request as ready for review January 19, 2024 15:29
@josecelano josecelano merged commit 62fddba into torrust:develop Jan 19, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Incorrect Behavior
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Panic running tracker after merging PR
1 participant