Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Build Log Downloader #63

Merged
merged 5 commits into from
Mar 30, 2019
Merged

Build Log Downloader #63

merged 5 commits into from
Mar 30, 2019

Conversation

toshi0383
Copy link
Owner

@toshi0383 toshi0383 commented Mar 15, 2019

#32

Added build log download feature.
Files are automatically deleted after 7 days.

Screenshot

Download via ActionSheet LogViewController
output IMG_6544

LogViewController

Performance issue

It takes too long to colorize large log file with Highlightr.
We should consider range access to the file instead of loading all content of the file at once.
I leave this as future TODO for now.

Color issue

Bitrise emits bash color format, so may be we can manually parse it to show cool colors like we see on Bitrise web console.

Screen Shot 2019-03-15 at 22 25 48

Is there any framework or 3rd party tool to do that on iOS UITextView ?

@toshi0383 toshi0383 added the enhancement New feature or request label Mar 15, 2019
@toshi0383 toshi0383 self-assigned this Mar 15, 2019
@codecov-io
Copy link

codecov-io commented Mar 19, 2019

Codecov Report

Merging #63 into master will decrease coverage by 1.68%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   14.84%   13.15%   -1.69%     
==========================================
  Files          48       50       +2     
  Lines        2136     2410     +274     
==========================================
  Hits          317      317              
- Misses       1819     2093     +274
Impacted Files Coverage Δ
...ent/Sources/List/Builds/BuildsListDataSource.swift 0% <0%> (ø) ⬆️
BitriseClient/Sources/List/Builds/BuildCell.swift 0% <0%> (ø) ⬆️
BitriseClient/Sources/Log/BuildLogDownloader.swift 0% <0%> (ø)
BitriseClient/Sources/AppDelegate.swift 6.45% <0%> (-0.33%) ⬇️
...ient/Sources/List/Builds/BuildsListViewModel.swift 0% <0%> (ø) ⬆️
...Sources/List/Builds/BuildsListViewController.swift 0% <0%> (ø) ⬆️
BitriseClient/Sources/Log/LogViewController.swift 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fc3cf7...15a7291. Read the comment docs.

@toshi0383 toshi0383 closed this Mar 20, 2019
@toshi0383 toshi0383 reopened this Mar 20, 2019
@toshi0383 toshi0383 merged commit 07f3c25 into master Mar 30, 2019
@toshi0383 toshi0383 deleted the log branch March 30, 2019 10:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants