Relax TargetRubyVersion
#107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The next version of RuboCop will drop Ruby 2.4 support. rubocop/rubocop#9648 This PR prevents the following error with edge RuboCop (and next stable RuboCop). ```console % bundle exec rubocop --parallel Error: RuboCop found unsupported Ruby version 2.4 in `TargetRubyVersion` parameter (in /Users/koic/.rbenv/versions/3.0.1/lib/ruby/gems/3.0.0/gems/ rubocop-rails_config-1.4.0/config/rails.yml). 2.4-compatible analysis was dropped after version 1.12. Supported versions: 2.5, 2.6, 2.7, 3.0 ``` The minimum Ruby supported version of the next RuboCop is 2.5. I think it would be beneficial for both UX and maintainability to omit `TargetRubyVersion` and delegate it to RuboCop core.
FYI: RuboCop 1.13.0 has been released. |
it sounds reasonable, let's delegate |
toshimaru
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next version of RuboCop will drop Ruby 2.4 support.
rubocop/rubocop#9648
This PR prevents the following error with edge RuboCop (and next stable RuboCop).
The minimum Ruby supported version of the next RuboCop is 2.5.
I think it would be beneficial for both UX and maintainability to omit
TargetRubyVersionand delegate it to RuboCop core.