Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require rubocop v1.48 #159

Merged
merged 3 commits into from
Apr 16, 2023
Merged

Require rubocop v1.48 #159

merged 3 commits into from
Apr 16, 2023

Conversation

toshimaru
Copy link
Owner

@toshimaru toshimaru commented Apr 15, 2023 •
edited

@koic
Copy link
Collaborator

koic commented Apr 15, 2023

JFYI, Rails development uses RuboCop 1.48 currently. So RuboCop 1.47 and lower supports can be dropped.
https://github.com/rails/rails/blob/cd5271b11ef298e694acc85a7e0c70580b1f340e/Gemfile.lock#L416

@toshimaru
ci: Drop rubocop 1.47 or less
6dc258c 
Since rails uses rubocop v1.48

see. rails/rails@dadf46d
@toshimaru
deps: Require rubocop v1.48 or more
4643649 
```
Gem rubocop-1.48.0
  json (~> 2.3)
  parallel (~> 1.10)
  parser (>= 3.2.0.0)
  rainbow (>= 2.2.2, < 4.0)
  regexp_parser (>= 1.8, < 3.0)
  rexml (>= 3.2.5, < 4.0)
  rubocop-ast (>= 1.26.0, < 2.0)
  ruby-progressbar (~> 1.7)
  unicode-display_width (>= 2.4.0, < 3.0)
```
@toshimaru toshimaru changed the title ci: Test against rubocop v1.46-v1.50 Require rubocop v1.48 Apr 16, 2023
@toshimaru toshimaru marked this pull request as ready for review April 16, 2023 03:20
@toshimaru toshimaru merged commit 5838a7c into main Apr 16, 2023
@toshimaru toshimaru deleted the add-more-rubocop-supports branch April 16, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@toshimaru @koic