Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a build error #164

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Fix a build error #164

merged 1 commit into from
Sep 16, 2023

Conversation

koic
Copy link
Collaborator

@koic koic commented Sep 13, 2023

This PR fixes the following build error:

(snip)
rubocop --except=Style/StringLiterals,Style/FrozenStringLiteralComment .
cp ./test/fixture/.rubocop.yml rails_test/.rubocop.yml
cd rails_test
Inspecting 28 files
C...........................

Offenses:

Gemfile:71:1: C: [Correctable] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end.

28 files inspected, 1 offense detected, 1 offense autocorrectable
rake aborted!

https://github.com/toshimaru/rubocop-rails_config/actions/runs/6167995304/job/16739825926

This is a regression in Rails 7.0.8, which will be resolved by rails/rails#49247. Until then, specifying the Layout/EmptyLinesAroundBlockBody cop is a workaround to prevent the build error.

This PR fixes the following build error:

```console
(snip)
rubocop --except=Style/StringLiterals,Style/FrozenStringLiteralComment .
cp ./test/fixture/.rubocop.yml rails_test/.rubocop.yml
cd rails_test
Inspecting 28 files
C...........................

Offenses:

Gemfile:71:1: C: [Correctable] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end.

28 files inspected, 1 offense detected, 1 offense autocorrectable
rake aborted!
```

https://github.com/toshimaru/rubocop-rails_config/actions/runs/6167995304/job/16739825926

This is a regression in Rails 7.0.8, which will be resolved by rails/rails#49247.
Until then, specifying the `Layout/EmptyLinesAroundBlockBody` cop is a workaround to prevent the build error.
Copy link
Owner

@toshimaru toshimaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice patch to Rails upstream 👍

@toshimaru toshimaru merged commit cc72308 into toshimaru:main Sep 16, 2023
36 checks passed
@koic koic deleted the fix_build_error branch September 16, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants