Changed CustomCops namespace to Rails for AssertNot

[5290charlie]

Noticed minor error popping up in vscode with the ruby-rubocop extension after updating to the rubocop-rails_config gem recently.

CustomCops/AssertNot has the wrong namespace - should be Rails

image of error message

I don't really know much about custom cops and why the namespace issue just started showing up, but out of curiosity I updated the module namespace from CustomCops to just Rails and that message stopped showing up!

I may be wrong with this somewhat ignorant assumption, but I thought I'd open a PR just in case it's an actual fix :)

Config

# .rubocop.yml

inherit_gem:
  rubocop-rails_config:
    - config/rails.yml

AllCops:
  TargetRubyVersion: 2.4.1
  Exclude:
    - 'db/**/*'
    - 'tmp/**/*'
    - 'bin/**/*'

Metrics/LineLength:
  Max: 100

Versions

# lsb_release -a
Distributor ID:	LinuxMint
Description:	Linux Mint 18.1 Serena
Release:	18.1
Codename:	serena

# rbenv --version
rbenv 1.1.1-37-g1c772d5

#ruby --version
ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]

# gem --version
2.6.11

# gem list
actionpack (5.2.0)
actionview (5.2.0)
activesupport (5.2.0)
ast (2.4.0)
bigdecimal (default: 1.3.0)
builder (3.2.3)
coderay (1.1.2)
concurrent-ruby (1.0.5)
crass (1.0.4)
did_you_mean (1.1.0)
erubi (1.7.1)
eventmachine (1.2.7)
htmlentities (4.3.4)
i18n (1.0.1)
io-console (default: 0.4.6)
jaro_winkler (1.5.1)
json (default: 2.0.2)
kramdown (1.17.0)
loofah (2.2.2)
method_source (0.9.0)
mini_portile2 (2.3.0)
minitest (5.10.1)
net-telnet (0.1.1)
nokogiri (1.8.4)
openssl (default: 2.0.3)
parallel (1.12.1)
parser (2.5.1.2)
power_assert (0.4.1)
powerpack (0.1.2)
psych (default: 2.2.2)
rack (2.0.5)
rack-test (1.0.0)
rails-dom-testing (2.0.3)
rails-html-sanitizer (1.0.4)
railties (5.2.0)
rainbow (3.0.0)
rake (12.0.0)
rdoc (default: 5.0.0)
reverse_markdown (1.1.0)
rubocop (0.58.1)
rubocop-rails (1.5.0)
rubocop-rails_config (0.1.3)
ruby-progressbar (1.9.0)
solargraph (0.23.5)
test-unit (3.2.3)
thor (0.20.0)
thread_safe (0.3.6)
tilt (2.0.8)
tzinfo (1.2.5)
unicode-display_width (1.4.0)
xmlrpc (0.2.1)
yard (0.9.14)

[brandoncabael]

I can also attest to this, I have been getting this although not in VS Code. It is happening when I run rubocop from the terminal. Making these changes locally fixes the issue.

Config

# .rubocop.yml
inherit_gem:
  rubocop-rails_config:
    - config/rails.yml
    
AllCops:
  TargetRubyVersion: 2.5.1
  Exclude:
    - 'db/**/*'
    - 'tmp/**/*'
    - 'bin/**/*'

Metrics/LineLength:
  Max: 105

Versions

lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Pop!_OS 18.04 LTS
Release:	18.04
Codename:	bionic

rbenv --version
rbenv 1.1.1-37-g1c772d5

ruby --version
ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux]

gem --version
2.7.6

gem list
actioncable (5.2.0)
actionmailer (5.2.0)
actionpack (5.2.0)
actionview (5.2.0)
active_model_serializers (0.10.7)
activejob (5.2.0)
activemodel (5.2.0)
activerecord (5.2.0)
activestorage (5.2.0)
activesupport (5.2.0)
airbrake-ruby (2.11.0)
api-pagination (4.8.1)
arel (9.0.0)
ast (2.4.0)
awesome_print (1.8.0)
aws-eventstream (1.0.1)
aws-partitions (1.96.0)
aws-sdk-core (3.22.1)
aws-sdk-kms (1.6.0)
aws-sdk-s3 (1.17.0)
aws-sigv4 (1.0.3)
axiom-types (0.1.1)
bcrypt (3.1.12)
better_errors (2.4.0)
bigdecimal (default: 1.3.4)
binding_of_caller (0.8.0)
bootsnap (1.3.1)
brakeman (4.3.1)
builder (3.2.3)
bullet (5.7.5)
bundler (default: 1.16.2)
bundler-audit (0.6.0)
byebug (10.0.2)
case_transform (0.2)
celluloid (0.17.3)
celluloid-essentials (0.20.5)
celluloid-extras (0.20.5)
celluloid-fsm (0.20.5)
celluloid-pool (0.20.5)
celluloid-supervision (0.20.6)
choice (0.2.0)
cmath (default: 1.0.0)
codeclimate-engine-rb (0.4.1)
coderay (1.1.2)
coercible (1.0.0)
concurrent-ruby (1.0.5)
connection_pool (2.2.2)
crass (1.0.4)
csv (default: 1.0.0)
database_cleaner (1.7.0)
date (default: 1.0.0)
dbm (default: 1.0.0)
debug_inspector (0.0.3)
descendants_tracker (0.0.4)
devise (4.4.3)
devise_token_auth (0.1.43)
did_you_mean (1.2.0)
diff-lcs (1.3)
domain_name (0.5.20180417)
dry-configurable (0.7.0)
dry-container (0.6.0)
dry-core (0.4.7)
dry-equalizer (0.2.1)
dry-inflector (0.1.2)
dry-logic (0.4.2)
dry-types (0.13.2)
dry-validation (0.12.1)
equalizer (0.0.11)
erubi (1.7.1)
etc (default: 1.0.0)
exception_notification (4.2.2)
factory_bot (4.10.0)
factory_bot_rails (4.10.0)
faker (1.9.1)
fast_jsonapi (1.3)
fcntl (default: 1.0.0)
ffi (1.9.25)
fiddle (default: 1.0.0)
fileutils (default: 1.0.2)
formatador (0.2.5)
gdbm (default: 2.0.0)
globalid (0.4.1)
guard (2.14.2)
guard-compat (1.2.1)
guard-rspec (4.7.3)
has_scope (0.7.2)
hitimes (1.3.0)
http-cookie (1.0.3)
httpclient (2.8.3)
i18n (1.0.1)
ice_nine (0.11.2)
image_processing (1.6.0)
io-console (default: 0.4.6)
ipaddr (default: 1.2.0)
jaro_winkler (1.5.1)
jmespath (1.4.0)
json (default: 2.1.0)
jsonapi-renderer (0.2.0)
jsonb_accessor (1.0.0)
kaminari (1.1.1)
kaminari-actionview (1.1.1)
kaminari-activerecord (1.1.1)
kaminari-core (1.1.1)
kwalify (0.7.2)
listen (3.1.5)
loofah (2.2.2)
lumberjack (1.0.13)
mail (2.7.0)
marcel (0.3.2)
method_source (0.9.0)
mime-types (3.1)
mime-types-data (3.2016.0521)
mimemagic (0.3.2)
mini_magick (4.8.0)
mini_mime (1.0.0)
mini_portile2 (2.3.0)
minitest (5.11.3, 5.10.3)
msgpack (1.2.4)
nenv (0.3.0)
net-telnet (0.1.1)
netrc (0.11.0)
nio4r (2.3.1)
nokogiri (1.8.4)
notiffany (0.1.1)
openssl (default: 2.1.0)
orm_adapter (0.5.0)
parallel (1.12.1)
parser (2.5.1.2)
pg (1.0.0)
power_assert (1.1.1)
powerpack (0.1.2)
pry (0.11.3)
pry-stack_explorer (0.4.9.2)
psych (default: 3.0.2)
pubnub (4.0.27)
puma (3.12.0)
pundit (1.1.0)
pundit-matchers (1.6.0)
rack (2.0.5)
rack-attack (5.4.0)
rack-cors (1.0.2)
rack-protection (2.0.3)
rack-test (1.0.0)
rails (5.2.0)
rails-dom-testing (2.0.3)
rails-erd (1.5.2)
rails-html-sanitizer (1.0.4)
railties (5.2.0)
rainbow (3.0.0)
rake (12.3.1, 12.3.0)
rb-fsevent (0.10.3)
rb-inotify (0.9.10)
rbtrace (0.4.10)
rdoc (default: 6.0.1)
redis (4.0.1)
reek (5.0.2)
responders (2.4.0)
rest-client (2.0.2)
rolify (5.2.0)
rspec (3.7.0)
rspec-core (3.7.1)
rspec-expectations (3.7.0)
rspec-mocks (3.7.0)
rspec-rails (3.7.2)
rspec-retry (0.6.1)
rspec-support (3.7.1)
rubocop (0.58.1)
rubocop-rails_config (0.1.3)
ruby-graphviz (1.2.3)
ruby-progressbar (1.9.0)
ruby-vips (2.0.12)
ruby_dep (1.5.0)
rubygems-update (2.7.7)
scanf (default: 1.0.0)
sdbm (default: 1.0.0)
shellany (0.0.1)
shoulda-matchers (3.1.2)
sidekiq (5.1.3)
simple_command (0.0.9)
slack-notifier (2.3.2)
spring (2.0.2)
spring-watcher-listen (2.0.1)
sprockets (3.7.2)
sprockets-rails (3.2.1)
stringio (default: 0.0.1)
strscan (default: 1.0.0)
test-unit (3.2.7)
thor (0.20.0)
thread_safe (0.3.6)
timers (4.1.2)
trollop (2.1.3)
tzinfo (1.2.5)
unf (0.1.4)
unf_ext (0.0.7.5)
unicode-display_width (1.4.0)
uniform_notifier (1.11.0)
virtus (1.0.5)
warden (1.2.7)
webrick (default: 1.4.2)
websocket-driver (0.7.0)
websocket-extensions (0.1.3)
xmlrpc (0.3.0)
zlib (default: 1.0.0)

[toshimaru]

@5290charlie thanks for sending PR. Actually, this is a known issue. ref. #2 (comment)

Can you rebase this code?

[5290charlie]

@toshimaru Oh, I must have missed that issue ... Can do! 👍

[5290charlie]

@toshimaru haven't really used rebase cross remotes ... shows changes from the toshimaru/master branch that I rebased from ... not sure why, let me know if this is ok, or if we need to rework these changes

[toshimaru]

@5290charlie Thanks for sending PR, the issue was fixed in v0.2.0.

(I added your name in Release Note! 😃 )