Continue the game when players drop out #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After registering the player's vote for persona we check if everybody voted and if so, we decide who won the round. Let's move this code to a function so we can reuse it later.
Check if the player who dropped was the last one remaining to vote for persona. Whenever a player drops we need to check if the game is waiting for a persona decision.
Move similar code to a function in Games service.
After registering the player's vote we check if everybody voted and if so, we decided who won the round. Let's move this code to a function so we can reuse it later.
Handle disconnection of player while players are voting on answers.
Let's user the number of rounds opposed to number of round winners. When a player who will win a round drops out before he sends his vote, the server won't add him to the list of roundWinners, as he won't be found in the list of players.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the server move on with the game when a player disconnects.
Whenever a player disconnects the server checks whether it got:
And continues the game if the player who dropped out was the only one left to send the answer vote, the answer or the persona vote.