-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 패키지가 노출하는 인터페이스를 명확히 하기 위해 index.ts를 named export로 수정합니다 #157
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"es-hangul": patch | ||
--- | ||
|
||
fix: 패키지가 노출하는 인터페이스를 명확히 하기 위해 index.ts를 named export로 수정합니다 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,21 @@ | ||
export * from './assemble'; | ||
export * from './chosungIncludes'; | ||
export * from './combineHangulCharacter'; | ||
export * from './convertQwertyToHangulAlphabet'; | ||
export * from './disassemble'; | ||
export * from './disassembleCompleteHangulCharacter'; | ||
export * from './hangulIncludes'; | ||
export * from './josa'; | ||
export * from './removeLastHangulCharacter'; | ||
export * from './utils'; | ||
export * from './extractHangul'; | ||
export * from './acronymizeHangul'; | ||
export { assembleHangul } from './assemble'; | ||
export { chosungIncludes } from './chosungIncludes'; | ||
export { combineHangulCharacter, combineVowels, curriedCombineHangulCharacter } from './combineHangulCharacter'; | ||
export { convertQwertyToHangul, convertQwertyToHangulAlphabet } from './convertQwertyToHangulAlphabet'; | ||
export { disassembleHangul, disassembleHangulToGroups } from './disassemble'; | ||
export { disassembleCompleteHangulCharacter } from './disassembleCompleteHangulCharacter'; | ||
export { hangulIncludes } from './hangulIncludes'; | ||
export { josa } from './josa'; | ||
export { removeLastHangulCharacter } from './removeLastHangulCharacter'; | ||
export { | ||
canBeChosung, | ||
canBeJongsung, | ||
canBeJungsung, | ||
getChosung, | ||
hasBatchim, | ||
hasProperty, | ||
hasSingleBatchim, | ||
hasValueInReadOnlyStringList, | ||
} from './utils'; | ||
export { extractHangul } from './extractHangul'; | ||
export { acronymizeHangul } from './acronymizeHangul'; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
모든 인터페이스가 *로 노출되면 안될 것 같아보여서(테스트용으로 export했을 수 있기 때문에) 현재 이미 노출되고 있는 것은 노출되도록 변경했습니다.
utils와 같은 폴더의 경우 노출되면 안되는 인터페이스 같아서 이슈로도 함께 남겨요. 잘못 노출된 인터페이스는 점진적으로 제거되면 좋을 거 같아요