Use task IDs to identify containing div (for JS extensibility) #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I was playing around with this library and wanted to show a little popover when a task is clicked to let users edit task details or something. I was going to do this with JS but there isn't really a way to pass the task div to JS. This small PR adds an id to the task containers on both the monthly & annual views (being a little presumptuous, I went with
task-{ID#}as the convention). This way I can usegetElementByIdand do some extra stuff with JS interop. Let me know if you have other thoughts on how to accomplish this though! Thanks!!