Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre v1 parameter tweaks #116

Merged
merged 4 commits into from
Apr 21, 2024
Merged

Pre v1 parameter tweaks #116

merged 4 commits into from
Apr 21, 2024

Conversation

JoseDiazRohena
Copy link
Contributor

@JoseDiazRohena JoseDiazRohena commented Apr 21, 2024

I'm giving the final parameter ranges one last pass in the hopes of getting it right enough
to avoid too much translation code down the line...

Values are derived from looking at other compressors, general thinking about compression and what control ranges are most useful, and playing around with some sounds.

The general questions

  • What is the actual maximum and minimum values that someone would want to use?
  • Where in the parameter range is precision more important? For example, changes to compression ratio are more significant for small ratios. So we set our Compress parameter such that the center of the range is skewed from the range's midpoint, causing less change in small ratios for the same amount of slider movement. It helps people find the "right" values, or at least the ideal operating ranges for the plugin.

Ideally, this would be validated by beta testing before release. One adjustment is based on feedback: the adjustment of the maximum attack time to 50 milliseconds. Some of it I'm not totally happy with, such as the way the Ratio values are skewed. But I've had it this way for a while and haven't found something I'm more satisfied with. So it remains!

@JoseDiazRohena JoseDiazRohena changed the title Jdr param tweaks Pre v1 parameter tweaks Apr 21, 2024
@JoseDiazRohena JoseDiazRohena marked this pull request as ready for review April 21, 2024 20:17
@JoseDiazRohena JoseDiazRohena merged commit a462da7 into main Apr 21, 2024
2 of 4 checks passed
@JoseDiazRohena JoseDiazRohena deleted the jdr-param-tweaks branch April 21, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant