Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added normalize option #50

Merged
merged 4 commits into from
May 28, 2020
Merged

Added normalize option #50

merged 4 commits into from
May 28, 2020

Conversation

saschazar21
Copy link
Contributor

This fixes issue #48.
Added an option to 'normalize' tags and exchange special characters like äøßç to their ASCII equivalents aossc.

This makes use of the safeTag() function and therefore depends on the value added to the slug property in the options object. However, for the standard RFC 3986 mentioned in the README, it should be a good fit.

@jarodtaylor jarodtaylor requested a review from hswolff October 6, 2017 17:40
@jarodtaylor
Copy link
Collaborator

@hswolff this PR looks good to go, but before merging I wasn't sure if you had some guidelines (e.g. bumping version numbers, etc.)

@hswolff
Copy link
Collaborator

hswolff commented Oct 7, 2017

Typically I follow the rule of "what's easiest for the contributor, and what's easiest for the maintainer". i.e. I ask what is required of the contributor for the PR to complete the work described and to not introduce any regressions (in code, style, etc), and from there I'm happy to do any other book-keeping that needs doing, i.e. bumping version numbers. Sometimes to even speed things along I'll be ok with updating documentation myself, however in this case there's no need thanks to @saschazar21 :).

Did I give you npm publish access @jarodtaylor? Happy for you to take complete ownership of this package.

@hswolff hswolff removed their request for review April 8, 2019 20:26
@gijswijs
Copy link
Collaborator

I agree with @jarodtaylor that this PR is good to go. This should result in a minor version bump. I don't have npm publish acces (yet) but I'm going to merge it anyway. Will check with @totocaster if I can get npm access.

@gijswijs gijswijs merged commit 0b11754 into totocaster:master May 28, 2020
@totocaster
Copy link
Owner

@gijswijs, sure DM me your npmjs.org username. It can't find you by gijswijs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants