Skip to content

Commit

Permalink
(E2E) testErrorChrome - Skip Backdrop and D8+ (much like D7)
Browse files Browse the repository at this point in the history
This test was added during 5.50.alpha (civicrm#23257, civicrm#22805).  It's purpose is to
assert that the page-chrome/site-wide-template is present on certain
error-messages; however, the underlying behavior was only implemented on
WordPress. It has not yet been implemented on other CMS.

Before
------

* __WordPress__: Runs testErrorChrome. Expected to pass.
* __Drupal 7__: Skip testErrorChrome (mostly) because it is expected to fail.
* __Drupal 8+, Backdrop__: Runs testErrorChrome. Fails.

After
-----

* __WordPress__: Runs testErrorChrome. Expected to pass.
* ___Drupal 7, Drupal 8+, Backdrop__: Skip testErrorChrome (mostly) because it is expected to fail.

Comment
-------

It still runs `testErrorChrome` for `permission` errors; per MM discussion, it appears that this does actually work, but we need
to tune assertion for BD+D8.
  • Loading branch information
totten committed May 6, 2022
1 parent 730ded6 commit af71951
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tests/phpunit/E2E/Core/ErrorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ class ErrorTest extends \CiviEndToEndTestCase {
// Format: "{$uf}_{$testFunc}_{$errorType}"
'/WordPress_testErrorStatus_(fatal|exception)/',
'/Drupal_testErrorChrome_(fatal|exception)/',
'/Drupal8_testErrorChrome_(fatal|exception)/',
'/Backdrop_testErrorChrome_(fatal|exception)/',
];

public function getErrorTypes() {
Expand Down

0 comments on commit af71951

Please sign in to comment.