Integrate ktlint and fix codestyle violations

.gitignore

@@ -10,3 +10,5 @@
 .cxx
 *.xcuserstate
 *.xcbkptlist
+!/.idea/codeStyles/*
+!/.idea/inspectionProfiles/*

app/build.gradle.kts

@@ -21,7 +21,7 @@ android {
         exclude("META-INF/*.kotlin_module")
     }
     buildTypes {
-        getByName("release")  {
+        getByName("release") {
             isMinifyEnabled = false
             proguardFiles(getDefaultProguardFile("proguard-android-optimize.txt"), "proguard-rules.pro")
         }
@@ -30,6 +30,11 @@ android {
         sourceCompatibility = JavaVersion.VERSION_1_8
         targetCompatibility = JavaVersion.VERSION_1_8
     }
+
+    lintOptions {
+        isWarningsAsErrors = true
+        isAbortOnError = true
+    }
 }
 
 dependencies {

app/src/main/AndroidManifest.xml

@@ -4,7 +4,7 @@
     <uses-permission android:name="android.permission.INTERNET"/>
 
     <application
-        android:allowBackup="true"
+        android:allowBackup="false"
         android:icon="@mipmap/ic_launcher"
         android:label="@string/app_name"
         android:roundIcon="@mipmap/ic_launcher_round"

app/src/main/java/co/touchlab/kampkit/android/BreedViewModel.kt

@@ -2,9 +2,9 @@ package co.touchlab.kampkit.android
 
 import androidx.lifecycle.MutableLiveData
 import androidx.lifecycle.ViewModel
+import androidx.lifecycle.viewModelScope
 import co.touchlab.kampkit.db.Breed
 import co.touchlab.kampkit.models.BreedModel
-import androidx.lifecycle.viewModelScope
 import co.touchlab.kampkit.models.ItemDataSummary
 import kotlinx.coroutines.flow.collect
 import kotlinx.coroutines.launch
@@ -19,7 +19,6 @@ class BreedViewModel : ViewModel() {
         observeBreeds()
     }
 
-
     private fun observeBreeds() {
         viewModelScope.launch {
             breedModel.selectAllBreeds().collect {
@@ -35,9 +34,9 @@ class BreedViewModel : ViewModel() {
             }
         }
     }
-    fun updateBreedFavorite(breed: Breed){
+    fun updateBreedFavorite(breed: Breed) {
         viewModelScope.launch {
             breedModel.updateBreedFavorite(breed)
         }
     }
-}
+}

app/src/main/java/co/touchlab/kampkit/android/MainActivity.kt

@@ -6,7 +6,6 @@ import androidx.lifecycle.Observer
 import androidx.lifecycle.ViewModelProviders
 import androidx.recyclerview.widget.LinearLayoutManager
 import co.touchlab.kampkit.android.adapter.MainAdapter
-import co.touchlab.kampkit.android.R
 import co.touchlab.kermit.Kermit
 import com.google.android.material.snackbar.Snackbar
 import kotlinx.android.synthetic.main.activity_main.*
@@ -19,25 +18,30 @@ class MainActivity : AppCompatActivity(), KoinComponent {
         val TAG = MainActivity::class.java.simpleName
     }
     private lateinit var adapter: MainAdapter
-    private val log:Kermit by inject { parametersOf("MainActivity") }
+    private val log: Kermit by inject { parametersOf("MainActivity") }
 
     private lateinit var viewModel: BreedViewModel
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         setContentView(R.layout.activity_main)
 
-
         viewModel = ViewModelProviders.of(this).get(BreedViewModel::class.java)
 
-        viewModel.breedLiveData.observe(this, Observer { itemData ->
-            log.v { "List submitted to adapter" }
-            adapter.submitList(itemData.allItems)
-        })
-        viewModel.errorLiveData.observe(this, Observer { errorMessage ->
-            log.e { "Error displayed: $errorMessage" }
-            Snackbar.make(breed_list, errorMessage, Snackbar.LENGTH_SHORT).show()
-        })
+        viewModel.breedLiveData.observe(
+            this,
+            Observer { itemData ->
+                log.v { "List submitted to adapter" }
+                adapter.submitList(itemData.allItems)
+            }
+        )
+        viewModel.errorLiveData.observe(
+            this,
+            Observer { errorMessage ->
+                log.e { "Error displayed: $errorMessage" }
+                Snackbar.make(breed_list, errorMessage, Snackbar.LENGTH_SHORT).show()
+            }
+        )
         adapter = MainAdapter {
             viewModel.updateBreedFavorite(it)
         }
@@ -47,4 +51,4 @@ class MainActivity : AppCompatActivity(), KoinComponent {
 
         viewModel.getBreedsFromNetwork()
     }
-}
+}

app/src/main/java/co/touchlab/kampkit/android/MainApp.kt

@@ -12,4 +12,4 @@ class MainApp : Application() {
             modules(module { single<Context> { this@MainApp } })
         }
     }
-}
+}

app/src/main/java/co/touchlab/kampkit/android/adapter/MainAdapter.kt

@@ -27,11 +27,10 @@ class MainAdapter(private val breedClickListener: (Breed) -> Unit) :
         private val breedCallback = object : DiffUtil.ItemCallback<Breed>() {
             override fun areContentsTheSame(oldItem: Breed, newItem: Breed): Boolean =
                 (oldItem.id == newItem.id) &&
-                        (oldItem.favorite == newItem.favorite)
+                    (oldItem.favorite == newItem.favorite)
 
             override fun areItemsTheSame(oldItem: Breed, newItem: Breed): Boolean =
                 oldItem.id == newItem.id
         }
     }
 }
-

app/src/main/java/co/touchlab/kampkit/android/adapter/MainViewHolder.kt

@@ -24,4 +24,4 @@ class MainViewHolder(itemView: View, breedClickListener: (Int) -> Unit) : Recycl
             favoriteButton.setBackgroundResource(R.drawable.ic_favorite_24px)
         }
     }
-}
+}

app/src/main/res/layout/item_breed.xml

@@ -1,9 +1,9 @@
 <?xml version="1.0" encoding="utf-8"?>
 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:tools="http://schemas.android.com/tools"
+    xmlns:app="http://schemas.android.com/apk/res-auto"
     android:layout_width="match_parent"
-    android:layout_height="wrap_content"
-    xmlns:app="http://schemas.android.com/apk/res-auto">
+    android:layout_height="wrap_content">
+
     <androidx.constraintlayout.widget.ConstraintLayout
         android:id="@+id/aboutTextBody"
         android:layout_width="match_parent"
@@ -15,22 +15,21 @@
             android:layout_width="wrap_content"
             android:layout_height="32dp"
             android:gravity="center_vertical"
+            android:text="@string/breed"
             android:textSize="22sp"
-            app:layout_constraintTop_toTopOf="parent"
             app:layout_constraintBottom_toBottomOf="parent"
             app:layout_constraintStart_toStartOf="parent"
-            android:text="TEST!23"
-            />
+            app:layout_constraintTop_toTopOf="parent" />
 
         <ImageButton
-            style="@style/Widget.AppCompat.Button.Borderless"
             android:id="@+id/favorite_button"
+            style="@style/Widget.AppCompat.Button.Borderless"
             android:layout_width="32dp"
             android:layout_height="32dp"
-            app:layout_constraintTop_toTopOf="parent"
+            android:contentDescription="@string/set_breed_as_a_favorite"
             app:layout_constraintBottom_toBottomOf="parent"
             app:layout_constraintEnd_toEndOf="parent"
-            />
+            app:layout_constraintTop_toTopOf="parent" />
 
     </androidx.constraintlayout.widget.ConstraintLayout>
 </FrameLayout>

app/src/main/res/values/strings.xml

@@ -1,3 +1,5 @@
 <resources>
     <string name="app_name">KaMP Kit</string>
+    <string name="set_breed_as_a_favorite">Set breed as a favorite</string>
+    <string name="breed">Breed</string>
 </resources>