This repository has been archived by the owner on Aug 27, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Security
Address CVE-2019-5477 (#1915)
A command injection vulnerability in Nokogiri v1.10.3 and earlier allows commands to be executed in a subprocess by Ruby's
Kernel.open
method. Processes are vulnerable only if the undocumented methodNokogiri::CSS::Tokenizer#load_file
is being passed untrusted user input.This vulnerability appears in code generated by the Rexical gem versions v1.0.6 and earlier. Rexical is used by Nokogiri to generate lexical scanner code for parsing CSS queries. The underlying vulnerability was addressed in Rexical v1.0.7 and Nokogiri upgraded to this version of Rexical in Nokogiri v1.10.4.
This CVE's public notice is CVE-2019-5477 - Nokogiri Command Injection Vulnerability sparklemotion/nokogiri#1915
Compare URL
rubocop-rails
New features
Rails/EnumHash
cop. ([@fedeagripa][], [@brunvez][], [@santib][])Bug fixes
Rails/SaveBang
when implicitly return using finder method and creation method connected by||
. ([@koic][])Rails/EnumUniqueness
. 1. Whenenum
name is not a literal. 2. Whenenum
has multiple definitions. ([@santib][])Changes
Rails/ActiveRecordAliases
asSafeAutoCorrect
false and disable autocorrect by default. ([@prathamesh-sonpatki][])Rails/SaveBang
asSafeAutoCorrect
false and disable autocorrect by default. ([@prathamesh-sonpatki][])create_or_find_by
inRails/SaveBang
cop. ([@MaximeLaurenty][])