-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import YouTube history into the rate later list #2059
base: main
Are you sure you want to change the base?
Conversation
Also, I added a button to the extension dropdown but it only opens a tab to the watch history, so I'm not sure it's useful. |
The videos that are already in the rate-later list appear as successfully imported, sounds good to me. |
Should we add the bulk import before releasing a first version of this feature? What do you think @amatissart ? Without the bulk import, the API allows authenticated users to make 120 requests per minute. This is very tight for an import process. If we decide to release a first version without the bulk import, we may want to manually control the pace of the import. I just lock myself out of tournesol.app by clicking five times on the import button. After that all import attempts fail : ] |
OK
OK I'll try that.
The title is indeed needed. A loading animation would really convey that something is happening. Maybe one of the CC0 pure CSS animations at https://loading.io/css/? Or maybe even a description of the process and a "start" button?
It doesn't seem very difficult to add the bulk import, so it's probably better to wait for it. I think I'll make the current API also accept an array of IDs as input. But if you'd rather have a new entry point, tell me. I don't know how heavy this process is to the backend. If it is, we may want a custom rate limit for this specific call (and that may warrant a specific entry point). The current version of the feature will do a call 1 second after the last request completed. |
c12170f
to
2f7b639
Compare
I made all the changes. It should work well, with a bulk import. I ended up using a specific API endpoint, but it can probably be merged into the existing create endpoint. |
Description
Initial draft to import your watch history into your rate later list.
The bulk import is not done yet, so the import is very slow, but it works.
Remaining to do: