Enforce http::Request<B> and http::Response<U> for our services #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpdrsn
approved these changes
Nov 22, 2021
Merged
|
Did we consider using a trait for the request and response to provide http::Request? I need to have a custom request and it seems to be incompatible with the current implementation. Would replacement of http::Request with IntoHttpRequest trait be an acceptable flexible solution? |
|
Please open a new issue for feature requests / discussions, instead of commenting on old PRs. That said, I don't think this is something we will at. If you need to convert types between two layers, you should be able to do so with another layer. If it's only for request or response, not both, I'd recommend tower's map_request / map_response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes: #164 and hopefully makes it less likely to require breaking changes in the future.