CORS middleware should set the Vary header #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The headers are based on [corsware][] which states: > These are all headers which can influence the outcome of any given > CORS request. Fixes tower-rs#198 [corsware]: https://github.com/atorstling/corsware/blob/3467805a74145b788f8234f9f994caf045509b31/src/lib.rs#L223-L229
davidpdrsn
approved these changes
Jan 3, 2022
There was a problem hiding this comment.
Thanks! This looks good to me.
It also matches what actix-web does (as of two days ago 😅)
I'll fix CI in a separate PR.
|
Changelog entry is missing, followup PR for that would probably be good? |
|
Yeah I noticed that. I'll just fill it in when doing a release. |
|
Actually I just did it in c99dd0a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The headers are based on corsware which states:
Fixes #198