Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tower-spawn-ready to std::future #332

Merged
merged 2 commits into from
Sep 10, 2019
Merged

Conversation

jonhoo
Copy link
Collaborator

@jonhoo jonhoo commented Sep 10, 2019

Will rebase and mark as ready once #330 lands (which this depends on)

@jonhoo jonhoo requested a review from LucioFranco September 10, 2019 05:04
@jonhoo
Copy link
Collaborator Author

jonhoo commented Sep 10, 2019

Bah, forgot to mark this as a draft. Oh well. I wonder why GitHub won't let me mark a PR as draft after the fact...

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed all the spawn ready code, looks like the rest is just artifacts of the other crates not getting merged yet.

@jonhoo jonhoo requested a review from LucioFranco September 10, 2019 18:41
@jonhoo
Copy link
Collaborator Author

jonhoo commented Sep 10, 2019

Removed the generic executor parameter in the latest commit.

@jonhoo jonhoo force-pushed the jonhoo/update-spawn-ready branch from 97ad3ed to fe4f602 Compare September 10, 2019 18:51
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonhoo jonhoo merged commit 1ca999f into v0.3.x Sep 10, 2019
@jonhoo jonhoo deleted the jonhoo/update-spawn-ready branch September 11, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants