Fix space not accepted in factor filter expression

Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
tox-dev · Dec 17, 2022 · 852c346 · 852c346
1 parent 9553e4f
commit 852c346
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/docs/changelog/2718.bugfix.rst b/docs/changelog/2718.bugfix.rst
@@ -0,0 +1 @@
+Fix space not accepted in factor filter expression - by :user:`gaborbernat`.
diff --git a/src/tox/config/loader/ini/factor.py b/src/tox/config/loader/ini/factor.py
@@ -48,7 +48,7 @@ def explode_factor(group: list[tuple[str, bool]]) -> str:
 
 def expand_factors(value: str) -> Iterator[tuple[Iterator[list[tuple[str, bool]]] | None, str]]:
     for line in value.split("\n"):
-        match = re.match(r"^((?P<factor_expr>[\w{}.!,-]+):\s+)?(?P<content>.*?)$", line)
+        match = re.match(r"^((?P<factor_expr>[\w {}.!,-]+):\s+)?(?P<content>.*?)$", line)
         if match is None:  # pragma: no cover
             raise RuntimeError("for a valid factor regex this cannot happen")
         groups = match.groupdict()

diff --git a/tests/config/loader/ini/test_factor.py b/tests/config/loader/ini/test_factor.py
@@ -27,6 +27,7 @@ def complex_example() -> str:
     py: py only
     !py: not py
     {py,!pi}-{a,b}{,-dev},c: complex
+    py, d: space
     extra: extra
     more-default
     """,
@@ -46,6 +47,7 @@ def test_factor_env_discover(complex_example: str) -> None:
         "pi-b",
         "pi-b-dev",
         "c",
+        "d",
         "extra",
     ]