Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.4 No Longer Supported due to Colorama Dependency #1483

Closed
mlammers86 opened this issue Dec 9, 2019 · 5 comments
Closed

Python 3.4 No Longer Supported due to Colorama Dependency #1483

mlammers86 opened this issue Dec 9, 2019 · 5 comments
Labels
bug:normal affects many people or has quite an impact

Comments

@mlammers86
Copy link

I don't use tox directly, or even close to indirectly, but a lot of packages that I depend on (awscli, for example) do. I also know that I shouldn't be using Python 3.4, but some of the software I maintain unfortunately does. On December 6, the package "colorama" dropped support for Python 3.4, and my new deploys are failing because of this. This package (tox) uses colorama >= 0.4.1 in setup.cfg, and because colorama 0.4.3 no longer supports Python 3.4, neither does anything else dependent on it.

Now, I might be totally wrong on all of this, but this is the only thing I can come up with as a reason why colorama is being installed from my requirements.txt file. Regardless, can you either change it to colorama == 0.4.1 in setup.cfg, or do something else to continue maintaining support for Python 3.4 for the time being? Thanks!

@mlammers86 mlammers86 added the bug:normal affects many people or has quite an impact label Dec 9, 2019
@mlammers86 mlammers86 changed the title Python 3.4 No Longer Supported Python 3.4 No Longer Supported due to Colorama Dependency Dec 9, 2019
@gaborbernat
Copy link
Member

Feel free to open a pr where you set it to greater or equal to 0.4.1 🤔

@ssbarnea
Copy link
Member

To be honest I would prefer dropping support for py34 in tox.

@asottile
Copy link
Contributor

@mlammers86 sounds like you're using a too-old version of pip? can you try using something newer (I think you need pip 9.0.1+)?

@jugmac00
Copy link
Member

jugmac00 commented Nov 9, 2020

Python 3.4 is no longer officially supported by tox.

I guess this issue could be closed then?

@mlammers86
Copy link
Author

mlammers86 commented Nov 9, 2020 via email

@asottile asottile closed this as completed Nov 9, 2020
@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug:normal affects many people or has quite an impact
Projects
None yet
Development

No branches or pull requests

5 participants