Allow user to inject specific Pythons to try as step 1 during discovery #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment it's unecessarily hard to specify a specific python executable to use for a given spec. While mangling with the path might work for environments for tox environments that require a python differing the host tox python version; for environments matching the host tox interpreter it's impossible to use any other interpreter than what tox uses. Here we add a CLI argument (fallback to some environment variable for CI usage) that allows the user to inject custom python interpreters as step 1 of the discovery mechanism. Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
bmwiedemann
added a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Mar 26, 2020
https://build.opensuse.org/request/show/786809 by user scarabeus_iv + dimstar_suse - Disable spinner tests as the monkeypatch changed behaviour in pytest - version update to 3.14.5 - Add ``--discover`` (fallback to ``TOX_DISCOVER`` environment variable via path separator) to inject python executables to try as first step of a discovery - note the executable still needs to match the environment by :user:`gaborbernat`. `#1526 <https://github.com/tox-dev/tox/issues/1526>`_ - Bump minimal six version needed to avoid using one incompatible with newer virtualenv. - by :user:`ssbarnea` `#1519 <https://github.com/tox-dev/tox/issues/1519>`_ - Avoid pypy test failure due to undefined printout var. - by :user:`ssbarnea` `#1521 <https://github.com/tox-dev/tox/issues/1521>`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment it's unnecessarily hard to specify a specific python
executable to use for a given spec. While mangling with the path
might work for environments for tox environments that require a python
differing the host tox python version; for environments matching the
host tox interpreter it's impossible to use any other interpreter than
what tox uses. Here we add a CLI argument (fallback to some environment
variable for CI usage) that allows the user to inject custom python
interpreters as step 1 of the discovery mechanism.
PS. Initially ran into this while trying to address pypa/virtualenv#1641, having multiple
pythonx.y(framework vs non-framework) versions installed in parallel found no way to force gracefully tox to use a given one.