Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Remove artefacts from old py34 support #1625

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

Djailla
Copy link

@Djailla Djailla commented Jul 23, 2020

Thanks for contributing a pull request!

Remove mention of no longer supported pyhon 3.4

Following #1525

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • [N/a] added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

docs/example/basic.rst Outdated Show resolved Hide resolved
docs/install.rst Show resolved Hide resolved
docs/index.rst Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
tox.ini Show resolved Hide resolved
docs/example/basic.rst Outdated Show resolved Hide resolved
@Djailla
Copy link
Author

Djailla commented Jul 23, 2020

@gaborbernat on a side question, do you consider dropping support of py27 soon ?

@gaborbernat
Copy link
Member

gaborbernat commented Jul 23, 2020

@gaborbernat on a side question, do you consider dropping support of py27 soon ?

tox 3 will probably never drop it, tox 4, which will be a complete rewrite will never support it.

@Djailla Djailla requested a review from gaborbernat July 23, 2020 14:42
@gaborbernat gaborbernat merged commit 10d9558 into tox-dev:master Jul 23, 2020
@Djailla Djailla deleted the py34 branch July 23, 2020 14:52
@Djailla Djailla restored the py34 branch July 23, 2020 14:52
@Djailla Djailla deleted the py34 branch July 23, 2020 14:52
ssbarnea pushed a commit to ssbarnea/tox that referenced this pull request Apr 19, 2021
Co-authored-by: Bastien Vallet <b.vallet@criteo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants