-
-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/development: Summarise important points experienced devs need to know #3197
Conversation
7a79d8e
to
7c1cce2
Compare
f3bfc04
to
6ec60ea
Compare
It doesn't look to me like that MacOS failure ( |
I think you're running into nedbat/coveragepy#1733, not much can do about it myself though. |
… know Experienced developers' eyes tend to quickly glaze over when reading developer documentation that starts with things like "how to clone a repo from GitHub." This new section at the top briefly covers key points specific to this project to help developers already familiar with Python development and GitHub PRs. This is based on my experience submitting my first PR to this project; it's what I wish I'd had to save me some time and conversation in the PR.
6ec60ea
to
4bcd5e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was made to my last accepted commit, so I presume it's something I should be doing normally. No changelog update because this is already covered by the tox-dev#3197 changelog going out in the next release.
This change was made to my last accepted commit, and looking back it's standard in a lot of commits, so it's clearly something developers should be doing normally. No changelog update because this is already covered by the tox-dev#3197 changelog going out in the next release.
This change was made to my last accepted commit, and looking back it's standard in a lot of commits, so it's clearly something developers should be doing normally. No changelog update because this is already covered by the tox-dev#3197 changelog going out in the next release.
This change was made to my last accepted commit, and looking back it's standard in a lot of commits, so it's clearly something developers should be doing normally. No changelog update because this is already covered by the tox-dev#3197 changelog going out in the next release.
See commit message for details.
tox -e fix
)docs/changelog
folder