Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display exception name when subprocesses raise them #3450

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Nov 19, 2024

This change provides more context information for cases like when a command is not found as previous behavior only returned the exist code of the exception, without any other information. Same exit codes could have being produced by commands that did run.

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@ssbarnea ssbarnea added the bug:minor does not affect many people or has no big impact label Nov 19, 2024
@ssbarnea ssbarnea marked this pull request as ready for review November 19, 2024 11:18
@ssbarnea ssbarnea force-pushed the fix/exit-code-2 branch 3 times, most recently from 22af201 to 33e162f Compare November 19, 2024 12:15
This change provides more context information for cases like when
a command is not found as previous behavior only returned the exist
code of the exception, without any other information. Same exit codes
could have being produced by commands that did run.
@ssbarnea ssbarnea merged commit dbbb043 into main Nov 19, 2024
28 checks passed
@ssbarnea ssbarnea deleted the fix/exit-code-2 branch November 19, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided bug:minor does not affect many people or has no big impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants