Keep message pointer valid by binding CString #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the docs of
as_ptr()
:I noticed that this causes an issue in
PamConv::send
, and fixed it by binding the CString to a variable, keeping it valid through the use of the pointer.Please let me know if there are any issues with my PR! Although it's short, I'm just learning Rust, so I would definitely appreciate correction on any pitfalls that I've fallen into :)