Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package has seen enough use (mostly for projects that I am involved in, as far as I know) to warrant some refactoring and API revamp. This is a list of ideas I want to work through, some may be split into a later PR, let's see. This may result in releasing version 1.0.
API
dimension
tobasis_dimension
anddomain
tobasis_domain
, to avoid clashes with other packages. These terms are not generic anyway.make_basis(family, grid_kind, dimspec)
should replaceunivariate_basis
andChebyshev
.family
should admitSmolyak(Chebyshev)
.dimspec
should allow integers as a shortcut, but maybe convert to types.Internals
linear_combination
may not be ideal for all work, implement one that reuses common subexpressions, unrollinglinear_combination
, most importantTensor
basis, cf this discussion. Implemented with the above features in mind. API could follow a "product" approach, eg overload×
Open questions