-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fedora 41 #122
Open
afreof
wants to merge
5
commits into
tpm2-software:master
Choose a base branch
from
afreof:fedora-41
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fedora 41 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Freihofer <adrian.freihofer@gmail.com>
Add missing -propquery '?provider=tpm2' to fix the tests e.g. on Fedora 40. Signed-off-by: Adrian Freihofer <adrian.freihofer@gmail.com>
Some distributions (Fedora 41) are starting to block sha1 hashes. This prevents this test case. Let's use sha256, which is more future-proof and should currently be supported by all distributions. Removing the following 2 lines from /etc/crypto-policies/back-ends/opensslcnf.config [evp_properties] rh-allow-sha1-signatures = no allows to run the tests successfully also with sha1. Signed-off-by: Adrian Freihofer <adrian.freihofer@gmail.com>
Some distributions (Fedora 41) are starting to block sha1 hashes. This prevents some test cases. The change is documented: https://fedoraproject.org/wiki/SHA1SignaturesGuidance. However, there is no API provided by openssl to detect if sha1 is supported or not. As a workaraound a scripts gets added which does that by singing and verifying some dummy data. Disabling sha1 by default was introduced to Fedora 41 by this commit: https://gitlab.com/redhat-crypto/fedora-crypto-policies/-/commit/035c735a8310af5e3999c327d96ad5e354837250 Removing the following 2 lines from /etc/crypto-policies/back-ends/opensslcnf.config [evp_properties] rh-allow-sha1-signatures = no allows to run the tests successfully also with sha1. The test log also shows that with sha1 supported the tests are executed and without sha1 support the tests are skipped for HASH=sha1. Signed-off-by: Adrian Freihofer <adrian.freihofer@gmail.com>
Tested on Fedora 40 host with: TEST_CONTAINER=ubuntu-2404 podman build -f "test/Containerfiles/Containerfile.$TEST_CONTAINER" \ --tag "tpm2-openssl-build-$TEST_CONTAINER" podman run -it --name tpm2-openssl-1 -v "$(pwd):/build:Z" --rm --userns=keep-id \ "localhost/tpm2-openssl-build-$TEST_CONTAINER" /bin/bash ubuntu@21852768f015:/$ /build/test/run-with-simulator Signed-off-by: Adrian Freihofer <adrian.freihofer@gmail.com>
The package is now in Fedrora Rawhide and #67 is solved. Would it be possible to create a new release? |
gentle ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default security policy of Fedora 41 is going to block SHA-1. This pull request adds support to the tests.
Fixes: https://bugzilla-attachments.redhat.com/attachment.cgi?id=2042901