Fix "tpm2_ptool verify --sopin" without "--userpin" #635
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using option `--sopin` in `tpm2_ptool verify`, `usersealauth` is not initialized but is being used. In practise, the value in `verify_output['wrappingkey']['auth']` is the same as the one in `verify_output['pin']['user']`, so make sure this is set only when the user PIN is really used. Fixes: tpm2-software#624 Signed-off-by: Nicolas Iooss <nicolas.iooss@ledger.fr>
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
=======================================
Coverage 74.25% 74.25%
=======================================
Files 33 33
Lines 8688 8688
=======================================
Hits 6451 6451
Misses 2237 2237 Continue to review full report at Codecov.
|
williamcroberts
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using option
--sopinintpm2_ptool verify,usersealauthis not initialized but is being used. In practise, the value inverify_output['wrappingkey']['auth']is the same as the one inverify_output['pin']['user'], so make sure this is set only when the user PIN is really used.Fixes: #624