Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: update --with-fapi configure option #824

Merged

Conversation

williamcroberts
Copy link
Member

Update configure.ac to use AC_ARG_WITH and update the docs to the proper argument. Keep the option the same for downstream packagers.

Fixes: #822

Update configure.ac to use AC_ARG_WITH and update the docs to the proper
argument. Keep the option the same for downstream packagers.

Fixes: tpm2-software#822

Signed-off-by: William Roberts <william.c.roberts@intel.com>
Fixes things like:
openssl req -provider tpm2 -provider base -new -x509 -days 365 -subj '/CN=my key/' -sha256 -key /tmp/tpm_simulator_TKIAAZ/14.pem --passin pass:1a4b7d67c5a2cce3f2a04cdaf1c062e3 -out /tmp/tpm_simulator_TKIAAZ/cert.pem.ec1
Error adding x509 extensions from section v3_ca
809BACAF177F0000:error:0308010C:digital envelope routines:inner_evp_generic_fetch:unsupported:../crypto/evp/evp_fetch.c:349:Global default library context, Algorithm (SHA1 : 94), Properties (<null>)
809BACAF177F0000:error:11000080:X509 V3 routines:X509V3_EXT_nconf_int:error in extension:../crypto/x509/v3_conf.c:48:section=v3_ca, name=subjectKeyIdentifier, value=hash

Signed-off-by: William Roberts <william.c.roberts@intel.com>
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #824 (7404ad1) into master (e8a3efd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #824   +/-   ##
=======================================
  Coverage   72.43%   72.43%           
=======================================
  Files          34       34           
  Lines        9773     9773           
=======================================
  Hits         7079     7079           
  Misses       2694     2694           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@williamcroberts williamcroberts merged commit 1b3aab9 into tpm2-software:master Mar 1, 2023
@williamcroberts williamcroberts deleted the fix-configure-option branch March 1, 2023 20:12
williamcroberts added a commit that referenced this pull request Sep 5, 2024
--enable-fapi was left as a vestigil to not break packagers and
conflicts with #824

We want folks to use `--with-fapi` everywhere, but keep supporting
enable-fapi for backwards compat (for now, packagers can move over
time).

This reverts commit bb95e3a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configure --with-fapi outdated tag
1 participant