UserID module: fix bug with userID init sometimes getting stuck in an…

… infinite loop (prebid#8362)

In some situations userID submodules can throw exceptions (prebid#8360) which then, after prebid#8201, causes the ID system to get stuck in an infinite loop.

modules/userId/index.js

@@ -520,6 +520,8 @@ function delayFor(ms) {
   return new Promise((resolve) => setTimeout(resolve, ms));
 }
 
+const INIT_CANCELED = {};
+
 function idSystemInitializer({delay = delayFor} = {}) {
   /**
    * @returns a {promise, resolve, reject} trio where `promise` is resolved by calling `resolve` or `reject`.
@@ -562,7 +564,7 @@ function idSystemInitializer({delay = delayFor} = {}) {
 
   function cancelAndTry(promise) {
     if (cancel != null) {
-      cancel.reject();
+      cancel.reject(INIT_CANCELED);
     }
     cancel = breakpoint();
     return Promise.race([promise, cancel.promise]);
@@ -803,8 +805,9 @@ function refreshUserIds({submoduleNames} = {}, callback) {
  * });
  * ```
  */
+
 function getUserIdsAsync() {
-  return initIdSystem().then(() => getUserIds(), () => getUserIdsAsync());
+  return initIdSystem().then(() => getUserIds(), (e) => e === INIT_CANCELED ? getUserIdsAsync() : Promise.reject(e));
 }
 
 /**

test/spec/modules/userId_spec.js

@@ -497,6 +497,14 @@ describe('User ID', function () {
           mockIdCallback.callArg(0, {id: {MOCKID: '1111'}});
         })
       });
+
+      it('should not get stuck when init fails', () => {
+        const err = new Error();
+        mockIdCallback.callsFake(() => { throw err; });
+        return getGlobal().getUserIdsAsync().catch((e) =>
+          expect(e).to.equal(err)
+        );
+      });
     });
 
     it('pbjs.refreshUserIds updates submodules', function(done) {