Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose a setting to disable automatic copen-ing #208

Merged
merged 1 commit into from
Jun 2, 2018

Conversation

shym
Copy link
Contributor

@shym shym commented Jul 22, 2017

Propose to extend the meaningful settings for the height of quickfix window with 0, to state that it should not be opened automatically. This is inspired by what happens with :make. I find this especially useful when I’m short on screen space (which is quite often).
This PR consists of one real commit, but it’s based on #207 since it modifies related lines.

Edit: changed the commit number to a reference to the PR.

@tpope
Copy link
Owner

tpope commented May 22, 2018

I guess I'm okay with using a height of zero as an undocumented way to surpress opening the quickfix window. I'm less keen on adding a -count to :Copen, as I'm thinking I might use the argument to open older commands, at some point.

copen and cwindow expect a positive number for the window height so we
can use the value 0 to state that the quickfix window should not be
opened or closed automatically
So when setting g:dispatch_quickfix_height to 0, `:Copen` updates the
quickfix list without opening the quickfix window and prevents the
quickfix window from opening on completion of a `:Dispatch` until the
next explicit `:copen`
@shym
Copy link
Contributor Author

shym commented Jun 2, 2018

Great. So I rebased the commit of this PR on master.
(After quite some time of using -count to set the height, I didn’t find it as convenient as I hoped anyway.)

@tpope
Copy link
Owner

tpope commented Jun 2, 2018

So I initially took this to only affect automatic opening. Having a manual call to :Copen not actually :copen is kind of weird. I guess I'm going to merge for now as an unofficial, undocumented behavior but will probably revisit at some point. Maybe I'll add :Cgetfile, or something. Vim 8's quickfix enhancements like :chistory have me rethinking how all this should work.

Side note, in #177 I see I said I'd accept -count. Guess I'm more fickle than even I realized.

@tpope tpope merged commit 6f93109 into tpope:master Jun 2, 2018
@shym
Copy link
Contributor Author

shym commented Jun 2, 2018

Great! And I agree that something along the lines of Cgetfile would be more elegant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants