Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making search highlight easier to see #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apeschel
Copy link

@apeschel apeschel commented Apr 3, 2012

The current colorscheme makes it difficult to see search highlighting on a black background. I have provided one possible solution to this problem.

@tpope
Copy link
Owner

tpope commented Jul 8, 2012

In my opinion, using grey makes it slightly easier to find, but slightly harder to read, and I favor the current implementation. What terminal are you using? Different terminals can have different color cubes, and I'm willing to take that into account.

@Arkham
Copy link

Arkham commented Jul 21, 2012

I have noticed this problem aswell and I'm using iTerm2 with the default dark background palette. I've found with some tinkering that my personal sweet spot is 82 (since it doesn't conflict with visual highlight), let me show you some examples:

Using 81:
vividchalk search 81

Using 82:
vividchalk search 82

Grey:
vividchalk search grey

@tpope
Copy link
Owner

tpope commented Jul 21, 2012

@Arkham iTerm2 supports 256 colors, yet the colors you cite hail from an 88 color terminal. What gives?

@Arkham
Copy link

Arkham commented Jul 22, 2012

I'm not exactly sure, do you see something obvious in my .vimrc? (https://github.com/Arkham/vimfiles/blob/master/vimrc)
I've also made a couple of screenshots of the vanilla vividchalk theme from iterm2 (http://i.imgur.com/pUBxY.png) and macvim (http://i.imgur.com/6sUGH.png) to show the color differences between the two. Am i doing something wrong? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants