Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data-export] Delete button does not check for 'toolingApi' parameter #254

Closed
1 task
tprouvot opened this issue Dec 28, 2023 · 2 comments
Closed
1 task

[data-export] Delete button does not check for 'toolingApi' parameter #254

tprouvot opened this issue Dec 28, 2023 · 2 comments
Assignees
@tprouvot
Labels
bug Something isn't working

Comments

@tprouvot
Copy link
Owner

tprouvot commented Dec 28, 2023 •
edited
Loading

Make sure to read the troubleshooting section before creating an issue

  • I've read the common issues and the one I'm about to create is not one of those documented.

Describe the bug
From data export page, when trying to delete records queried with tooling api, the api is not automatically selected.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'data-export'
  2. Query SELECT Id from TraceFlag
  3. Click 'Delete Records' buttons
  4. Deletion is not possible since we should use Tooling api and not Entreprise api
image

Desktop (please complete the following information):

  • OS: MAC
  • Browser chrome
  • Version 1.21
@tprouvot tprouvot added the bug Something isn't working label Dec 28, 2023
@tprouvot tprouvot self-assigned this Dec 28, 2023
@tprouvot
Copy link
Owner Author

Hi @ogomezba !
Just for information, there was a rework on the API selection for supporting CMDT upsert, maybe it's a regression.
Let me know if you want to take a look at it, otherwise I'll address it.

@ogomezba
Copy link
Contributor

Hi @tprouvot! Yes, I was going to open an issue for this! I want to work on it indeed, thank you for creating it!

ogomezba added a commit to ogomezba/Salesforce-Inspector-reloaded that referenced this issue Dec 29, 2023
@ogomezba
fix: Fix for issue tprouvot#254
d016a2a 
Fixing the Delete button for the cases where the "Tooling API" option
has been selected when querying
@ogomezba ogomezba mentioned this issue Dec 29, 2023
Merged
6 tasks
tprouvot pushed a commit that referenced this issue Jan 2, 2024
@ogomezba
fix: Fix for issue #254 (#256)
b62a6d9 
Fixing the Delete button for the cases where the "Tooling API" option
has been selected when querying

## Describe your changes
Included logic for sending the apiType as a parameter to the
data-import.

## Issue ticket number and link
[Issue
254](#254)

## Checklist before requesting a review
- [x] I have read and understand the [Contributions
section](https://github.com/tprouvot/Salesforce-Inspector-reloaded#contributions)
- [x] Target branch is releaseCandidate and not master
- [x] I have performed a self-review of my code
- [x] I ran the [unit
tests](https://github.com/tprouvot/Salesforce-Inspector-reloaded#unit-tests)
and my PR does not break any tests
- [x] I documented the changes I've made on the
[CHANGES.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/CHANGES.md)
and followed actual conventions
- [x] I added a new section on
[how-to.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/docs/how-to.md)
(optional)
@tprouvot tprouvot closed this as completed Jan 2, 2024
AntoineLeleu-Salesforce pushed a commit to AntoineLeleu-Salesforce/Salesforce-Inspector-reloaded that referenced this issue Jan 4, 2024
@ogomezba @AntoineLeleu-Salesforce
fix: Fix for issue tprouvot#254 (tprouvot#256)
995cee0 
Fixing the Delete button for the cases where the "Tooling API" option
has been selected when querying

## Describe your changes
Included logic for sending the apiType as a parameter to the
data-import.

## Issue ticket number and link
[Issue
254](tprouvot#254)

## Checklist before requesting a review
- [x] I have read and understand the [Contributions
section](https://github.com/tprouvot/Salesforce-Inspector-reloaded#contributions)
- [x] Target branch is releaseCandidate and not master
- [x] I have performed a self-review of my code
- [x] I ran the [unit
tests](https://github.com/tprouvot/Salesforce-Inspector-reloaded#unit-tests)
and my PR does not break any tests
- [x] I documented the changes I've made on the
[CHANGES.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/CHANGES.md)
and followed actual conventions
- [x] I added a new section on
[how-to.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/docs/how-to.md)
(optional)
AntoineLeleu-Salesforce pushed a commit to AntoineLeleu-Salesforce/Salesforce-Inspector-reloaded that referenced this issue Jan 4, 2024
@ogomezba @AntoineLeleu-Salesforce
fix: Fix for issue tprouvot#254 (tprouvot#256)
5c85f2d 
Fixing the Delete button for the cases where the "Tooling API" option
has been selected when querying

## Describe your changes
Included logic for sending the apiType as a parameter to the
data-import.

## Issue ticket number and link
[Issue
254](tprouvot#254)

## Checklist before requesting a review
- [x] I have read and understand the [Contributions
section](https://github.com/tprouvot/Salesforce-Inspector-reloaded#contributions)
- [x] Target branch is releaseCandidate and not master
- [x] I have performed a self-review of my code
- [x] I ran the [unit
tests](https://github.com/tprouvot/Salesforce-Inspector-reloaded#unit-tests)
and my PR does not break any tests
- [x] I documented the changes I've made on the
[CHANGES.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/CHANGES.md)
and followed actual conventions
- [x] I added a new section on
[how-to.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/docs/how-to.md)
(optional)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tprouvot tprouvot

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tprouvot @ogomezba