confidential clientのサポート(client typeを選択可能に) #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyosu-1
changed the title
|
traPtitech/traQ-bot-console#538 |
kaitoyama
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
背景は #2402 に記載の通りです
defaultがpublic clientでconfidential clientが選択不可能だったところを、confidential clientかpublic clientを登録時に選択可能に(&取得時にconfidential filedを追加)しました。
後方互換性の観点から、POST時はconfidential フィールドは not requiredかつ、default値をfalse(public client)としています。
clientTypeというフィールドを追加して(confidentialとpublicの)enumにする実装方針もありましたが、実装が単純になるboolean(DBと同じ型)のconfidential フィールドを持たせる形にしました