DSNをDSNconfigを使用する形に変更 #2465
Merged
DSNをDSNconfigを使用する形に変更 #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pikachu0310
requested changes
Jul 1, 2024
repository/gorm/repository_test.go
Outdated
Comment on lines
69
to
71
| config.DBName = fmt.Sprintf("%s%s", dbPrefix, key) | ||
| engine, err := gorm.Open(mysql.New(mysql.Config{ | ||
| DSN: fmt.Sprintf("%s:%s@tcp(%s:%s)/%s?charset=utf8mb4&parseTime=true", user, pass, host, port, fmt.Sprintf("%s%s", dbPrefix, key)), | ||
| DSNConfig: config, |
There was a problem hiding this comment.
結構細かいですが、
この実装は config.DBName = fmt.Sprintf("%s%s", dbPrefix, key) と config 構造体の元の値を直接変更してるけど、以下の様に元の値を直接変更するのではなくコピーしてから変更した方が、コードの意図が明確になって、さらに他の部分への影響を防ぐことでメンテナンス上でバグが起きにくくなりそうです！
Suggested change
| config.DBName = fmt.Sprintf("%s%s", dbPrefix, key) | |
| engine, err := gorm.Open(mysql.New(mysql.Config{ | |
| DSN: fmt.Sprintf("%s:%s@tcp(%s:%s)/%s?charset=utf8mb4&parseTime=true", user, pass, host, port, fmt.Sprintf("%s%s", dbPrefix, key)), | |
| DSNConfig: config, | |
| dbConfig := *config | |
| dbConfig.DBName = fmt.Sprintf("%s%s", dbPrefix, key) | |
| engine, err := gorm.Open(mysql.New(mysql.Config{ | |
| DSNConfig: &dbConfig, |
router/oauth2/oauth2_test.go
Outdated
Comment on lines
67
to
71
| config.DBName = fmt.Sprintf("%s%s", dbPrefix, key) | ||
|
|
||
| // テスト用データベース接続 | ||
| engine, err := gorm.Open(mysql.New(mysql.Config{ | ||
| DSN: fmt.Sprintf("%s:%s@tcp(%s:%s)/%s?charset=utf8mb4&parseTime=true", user, pass, host, port, fmt.Sprintf("%s%s", dbPrefix, key)), | ||
| DSNConfig: config, |
router/v3/router_test.go
Outdated
Comment on lines
79
to
84
| config.DBName = fmt.Sprintf("%s%s", dbPrefix, key) | ||
| l := zap.NewNop() | ||
|
|
||
| // テスト用データベース接続 | ||
| engine, err := gorm.Open(mysql.New(mysql.Config{ | ||
| DSN: fmt.Sprintf("%s:%s@tcp(%s:%s)/%s?charset=utf8mb4&parseTime=true", user, pass, host, port, fmt.Sprintf("%s%s", dbPrefix, key)), | ||
| DSNConfig: config, |
pikachu0310
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve: #1873