UUIDの生成を、UUIDv4からUUIDv7にする #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
comment: テストのところも uuid v7 に書き換えたいが、v7 の知識をもとにプログラムが書かれても困るので（現状の運用的に）v4 / v7 がどっちも振ってくるテストを書くと良い…？ |
|
Takeno-hito
approved these changes
Jun 27, 2024
kyosu-1
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2424
とりあえず全ての
uuid.NewV4をuuid.NewV7に置き換えてみました。uuid.NewV3はいじっていません。セキュリティ上の問題がないかが少し心配です。
というのも、仮にトークン的な役割で UUIDv4 を使っている箇所がある場合、そこを v7 にしたことでランダム性が落ちてしまうと考えられるからです。