Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BotのPACHにbioフィールドを追加 #2483

Merged
merged 4 commits into from
Jul 23, 2024
Merged

BotのPACHにbioフィールドを追加 #2483

merged 4 commits into from
Jul 23, 2024
+22 −0

Conversation

UnABC
Copy link

@UnABC UnABC commented Jul 13, 2024 •
edited by Takeno-hito
Loading

close: #2035

Takeno-hito
Takeno-hito reviewed Jul 16, 2024
View reviewed changes
Copy link
Member

@Takeno-hito Takeno-hito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM traQ メンバーからレビューをもらってください！

@Takeno-hito
Copy link
Member

Takeno-hito commented Jul 16, 2024 •
edited
Loading

close: #2035 コメントだと意味ないらしい

kaitoyama
kaitoyama requested changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@kaitoyama kaitoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
レビューしましたので、確認お願いします!

router/v3/bots.go Show resolved Hide resolved
docs/v3-api.yaml Outdated Show resolved Hide resolved
pikachu0310
pikachu0310 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@pikachu0310 pikachu0310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです！(レビューリクエストは飛んできてないのですが、既に修正されてそうなので見ました！)

kaitoyama
kaitoyama approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@kaitoyama kaitoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@pikachu0310 pikachu0310 merged commit 9918b0c into master Jul 23, 2024
11 checks passed
@pikachu0310 pikachu0310 deleted the issue2035 branch July 23, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Takeno-hito Takeno-hito Takeno-hito left review comments

@kaitoyama kaitoyama kaitoyama approved these changes

@pikachu0310 pikachu0310 pikachu0310 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

botのbioをそれぞれの情報更新用APIで変更したい
4 participants
@UnABC @Takeno-hito @pikachu0310 @kaitoyama