Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ファイルサイズが上限を超えたらエラートーストを出すように #4049

Merged
merged 6 commits into from
Oct 24, 2023

Conversation

mehm8128
Copy link
Contributor

@mehm8128 mehm8128 commented Aug 20, 2023

close #3933

あとトースト内のテキストに改行文字があっても改行されないことに気づいたので直しました

画像は↓から色んなサイズの画像がダウンロードできます
https://esahubble.org/images/heic1901a/#:~:text=Galaxies-,Image%20Formats,-Fullsize%20Original

@mehm8128 mehm8128 self-assigned this Aug 20, 2023
@github-actions
Copy link

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

src/lib/resize/index.ts Outdated Show resolved Hide resolved
@mehm8128 mehm8128 requested a review from nokhnaton August 20, 2023 05:52
nokhnaton
nokhnaton previously approved these changes Aug 20, 2023
Copy link
Contributor

@nokhnaton nokhnaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうです

ras0q
ras0q previously approved these changes Sep 2, 2023
Copy link
Member

@ras0q ras0q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました

@mehm8128 mehm8128 changed the title 画像も30MBまで許容するように&超えたらエラートーストを出すように ファイルサイズが上限を超えたらエラートーストを出すように Oct 18, 2023
@mehm8128
Copy link
Contributor Author

画像だけ20MBなのはちゃんと理由あったので、変更消しました
トーストのメッセージが上手く改行されてなかった問題と、ファイルサイズが上限超えたときにトースト表示されてなかったのだけ直すようにしたので確認お願いします
https://q.trap.jp/messages/4445a849-18cc-4a74-8d7b-28b63eb1a8a7

@mehm8128 mehm8128 requested review from nokhnaton and ras0q October 18, 2023 16:14
@mehm8128 mehm8128 dismissed stale reviews from ras0q and nokhnaton October 21, 2023 04:07

修正したため、approve消しときます

Copy link
Contributor

@nokhnaton nokhnaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehm8128 mehm8128 merged commit 64acea0 into master Oct 24, 2023
11 checks passed
@mehm8128 mehm8128 deleted the fix/big_file_validation branch October 24, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ファイルのサイズが大きくて送れないときにエラーを表示する
3 participants